opendev/gerrit
Code Issues Proposed changes

Rename ReindexAfterUpdate -> ReindexAfterRefUpdate

Browse Source 
Make it clearer what kind of update we're talking about. This may be
implied by the fact that it implements GitReferenceUpdatedListener, but
this fact is not necessarily obvious at call sites.

Change-Id: If7340a0b63d3ce96f5e58ccdddefd77056ff2805
This commit is contained in:
Dave Borowitz
2017-04-17 16:50:23 -04:00
parent 4e2d339e2f
commit 14ec59decc
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java
View File

@@ -48,7 +48,7 @@ import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.git.GitRepositoryManager; import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.git.WorkQueue; import com.google.gerrit.server.git.WorkQueue;
import com.google.gerrit.server.index.DummyIndexModule; import com.google.gerrit.server.index.DummyIndexModule;
import com.google.gerrit.server.index.change.ReindexAfterUpdate; import com.google.gerrit.server.index.change.ReindexAfterRefUpdate;
import com.google.gerrit.server.notedb.ChangeBundleReader; import com.google.gerrit.server.notedb.ChangeBundleReader;
import com.google.gerrit.server.notedb.NoteDbUpdateManager; import com.google.gerrit.server.notedb.NoteDbUpdateManager;
import com.google.gerrit.server.notedb.NotesMigration; import com.google.gerrit.server.notedb.NotesMigration;
@@ -212,7 +212,7 @@ public class RebuildNoteDb extends SiteProgram {
public void configure() { public void configure() {
install(dbInjector.getInstance(BatchProgramModule.class)); install(dbInjector.getInstance(BatchProgramModule.class));
DynamicSet.bind(binder(), GitReferenceUpdatedListener.class) DynamicSet.bind(binder(), GitReferenceUpdatedListener.class)
.to(ReindexAfterUpdate.class); .to(ReindexAfterRefUpdate.class);
install(new DummyIndexModule()); install(new DummyIndexModule());
factory(ChangeResource.Factory.class); factory(ChangeResource.Factory.class);
} }

4
gerrit-server/src/main/java/com/google/gerrit/server/config/GerritGlobalModule.java
View File

@@ -132,7 +132,7 @@ import com.google.gerrit.server.git.validators.RefOperationValidators;
import com.google.gerrit.server.git.validators.UploadValidationListener; import com.google.gerrit.server.git.validators.UploadValidationListener;
import com.google.gerrit.server.git.validators.UploadValidators; import com.google.gerrit.server.git.validators.UploadValidators;
import com.google.gerrit.server.group.GroupModule; import com.google.gerrit.server.group.GroupModule;
import com.google.gerrit.server.index.change.ReindexAfterUpdate; import com.google.gerrit.server.index.change.ReindexAfterRefUpdate;
import com.google.gerrit.server.mail.EmailModule; import com.google.gerrit.server.mail.EmailModule;
import com.google.gerrit.server.mail.ListMailFilter; import com.google.gerrit.server.mail.ListMailFilter;
import com.google.gerrit.server.mail.MailFilter; import com.google.gerrit.server.mail.MailFilter;
@@ -330,7 +330,7 @@ public class GerritGlobalModule extends FactoryModule {
DynamicSet.setOf(binder(), GarbageCollectorListener.class); DynamicSet.setOf(binder(), GarbageCollectorListener.class);
DynamicSet.setOf(binder(), HeadUpdatedListener.class); DynamicSet.setOf(binder(), HeadUpdatedListener.class);
DynamicSet.setOf(binder(), UsageDataPublishedListener.class); DynamicSet.setOf(binder(), UsageDataPublishedListener.class);
DynamicSet.bind(binder(), GitReferenceUpdatedListener.class).to(ReindexAfterUpdate.class); DynamicSet.bind(binder(), GitReferenceUpdatedListener.class).to(ReindexAfterRefUpdate.class);
DynamicSet.bind(binder(), GitReferenceUpdatedListener.class) DynamicSet.bind(binder(), GitReferenceUpdatedListener.class)
.to(ProjectConfigEntry.UpdateChecker.class); .to(ProjectConfigEntry.UpdateChecker.class);
DynamicSet.setOf(binder(), EventListener.class); DynamicSet.setOf(binder(), EventListener.class);

6
gerrit-server/src/main/java/com/google/gerrit/server/index/change/ReindexAfterUpdate.java → gerrit-server/src/main/java/com/google/gerrit/server/index/change/ReindexAfterRefUpdate.java
View File

@@ -44,8 +44,8 @@ import java.util.concurrent.Future;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
public class ReindexAfterUpdate implements GitReferenceUpdatedListener { public class ReindexAfterRefUpdate implements GitReferenceUpdatedListener {
private static final Logger log = LoggerFactory.getLogger(ReindexAfterUpdate.class); private static final Logger log = LoggerFactory.getLogger(ReindexAfterRefUpdate.class);
private final OneOffRequestContext requestContext; private final OneOffRequestContext requestContext;
private final Provider<InternalChangeQuery> queryProvider; private final Provider<InternalChangeQuery> queryProvider;
@@ -55,7 +55,7 @@ public class ReindexAfterUpdate implements GitReferenceUpdatedListener {
private final ListeningExecutorService executor; private final ListeningExecutorService executor;
@Inject @Inject
ReindexAfterUpdate( ReindexAfterRefUpdate(
OneOffRequestContext requestContext, OneOffRequestContext requestContext,
Provider<InternalChangeQuery> queryProvider, Provider<InternalChangeQuery> queryProvider,
ChangeIndexer.Factory indexerFactory, ChangeIndexer.Factory indexerFactory,