Merge "ChangeUtil: Delete draft change inside database transaction" into stable-2.11

gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java

@@ -57,7 +57,9 @@ import com.google.inject.Singleton;
 import org.eclipse.jgit.errors.IncorrectObjectTypeException;
 import org.eclipse.jgit.errors.MissingObjectException;
 import org.eclipse.jgit.errors.RepositoryNotFoundException;
+import org.eclipse.jgit.lib.BatchRefUpdate;
 import org.eclipse.jgit.lib.CommitBuilder;
+import org.eclipse.jgit.lib.NullProgressMonitor;
 import org.eclipse.jgit.lib.ObjectId;
 import org.eclipse.jgit.lib.ObjectInserter;
 import org.eclipse.jgit.lib.PersonIdent;
@@ -78,6 +80,7 @@ import java.text.MessageFormat;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Date;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -422,15 +425,39 @@ public class ChangeUtil {
     }
 
     ReviewDb db = this.db.get();
-    for (PatchSet ps : db.patchSets().byChange(changeId)) {
+    db.changes().beginTransaction(change.getId());
-      // These should all be draft patch sets.
+    try {
-      deleteOnlyDraftPatchSet(ps, change);
+      Map<RevId, String> refsToDelete = new HashMap<>();
-    }
+      for (PatchSet ps : db.patchSets().byChange(changeId)) {
+        // These should all be draft patch sets.
+        deleteOnlyDraftPatchSetPreserveRef(db, ps);
+        refsToDelete.put(ps.getRevision(), ps.getRefName());
+      }
+      db.changeMessages().delete(db.changeMessages().byChange(changeId));
+      db.starredChanges().delete(db.starredChanges().byChange(changeId));
+      db.changes().delete(Collections.singleton(change));
 
-    db.changeMessages().delete(db.changeMessages().byChange(changeId));
+      // Delete all refs at once
-    db.starredChanges().delete(db.starredChanges().byChange(changeId));
+      try (Repository repo = gitManager.openRepository(change.getProject());
-    db.changes().delete(Collections.singleton(change));
+          RevWalk rw = new RevWalk(repo)) {
-    indexer.delete(change.getId());
+        BatchRefUpdate ru = repo.getRefDatabase().newBatchUpdate();
+        for (Map.Entry<RevId, String> e : refsToDelete.entrySet()) {
+          ru.addCommand(new ReceiveCommand(ObjectId.fromString(e.getKey().get()),
+              ObjectId.zeroId(), e.getValue()));
+        }
+        ru.execute(rw, NullProgressMonitor.INSTANCE);
+        for (ReceiveCommand cmd : ru.getCommands()) {
+          if (cmd.getResult() != ReceiveCommand.Result.OK) {
+            throw new IOException("failed: " + cmd);
+          }
+        }
+      }
+
+      db.commit();
+      indexer.delete(change.getId());
+    } finally {
+      db.rollback();
+    }
   }
 
   public void deleteOnlyDraftPatchSet(PatchSet patch, Change change)
@@ -461,15 +488,7 @@ public class ChangeUtil {
       repo.close();
     }
 
-    ReviewDb db = this.db.get();
+    deleteOnlyDraftPatchSetPreserveRef(this.db.get(), patch);
-    db.accountPatchReviews().delete(db.accountPatchReviews().byPatchSet(patchSetId));
-    db.changeMessages().delete(db.changeMessages().byPatchSet(patchSetId));
-    // No need to delete from notedb; draft patch sets will be filtered out.
-    db.patchComments().delete(db.patchComments().byPatchSet(patchSetId));
-    db.patchSetApprovals().delete(db.patchSetApprovals().byPatchSet(patchSetId));
-    db.patchSetAncestors().delete(db.patchSetAncestors().byPatchSet(patchSetId));
-
-    db.patchSets().delete(Collections.singleton(patch));
   }
 
   /**
@@ -511,6 +530,23 @@ public class ChangeUtil {
     return (IdentifiedUser) userProvider.get();
   }
 
+  private static void deleteOnlyDraftPatchSetPreserveRef(ReviewDb db,
+      PatchSet patch) throws NoSuchChangeException, OrmException {
+    PatchSet.Id patchSetId = patch.getId();
+    if (!patch.isDraft()) {
+      throw new NoSuchChangeException(patchSetId.getParentKey());
+    }
+
+    db.accountPatchReviews().delete(db.accountPatchReviews().byPatchSet(patchSetId));
+    db.changeMessages().delete(db.changeMessages().byPatchSet(patchSetId));
+    // No need to delete from notedb; draft patch sets will be filtered out.
+    db.patchComments().delete(db.patchComments().byPatchSet(patchSetId));
+    db.patchSetApprovals().delete(db.patchSetApprovals().byPatchSet(patchSetId));
+    db.patchSetAncestors().delete(db.patchSetAncestors().byPatchSet(patchSetId));
+
+    db.patchSets().delete(Collections.singleton(patch));
+  }
+
   public static PatchSet.Id nextPatchSetId(PatchSet.Id id) {
     return new PatchSet.Id(id.getParentKey(), id.get() + 1);
   }