diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/CreateProjectIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/CreateProjectIT.java index cdf671d02a..f636f11bf9 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/CreateProjectIT.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/CreateProjectIT.java @@ -252,7 +252,6 @@ public class CreateProjectIT extends AbstractDaemonTest { tw.reset(); } } finally { - tw.release(); rw.release(); repo.close(); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/GetContent.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/GetContent.java index bfc1df9319..0ac3e1a555 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/GetContent.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/GetContent.java @@ -62,19 +62,15 @@ public class GetContent implements RestReadView { if (tw == null) { throw new ResourceNotFoundException(); } - try { - final ObjectLoader object = repo.open(tw.getObjectId(0)); - @SuppressWarnings("resource") - BinaryResult result = new BinaryResult() { - @Override - public void writeTo(OutputStream os) throws IOException { - object.copyTo(os); - } - }; - return result.setContentLength(object.getSize()).base64(); - } finally { - tw.release(); - } + final ObjectLoader object = repo.open(tw.getObjectId(0)); + @SuppressWarnings("resource") + BinaryResult result = new BinaryResult() { + @Override + public void writeTo(OutputStream os) throws IOException { + object.copyTo(os); + } + }; + return result.setContentLength(object.getSize()).base64(); } finally { rw.release(); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListDashboards.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListDashboards.java index fbfcc8f604..07fd095f74 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ListDashboards.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ListDashboards.java @@ -112,29 +112,25 @@ class ListDashboards implements RestReadView { throws IOException { List list = Lists.newArrayList(); TreeWalk tw = new TreeWalk(rw.getObjectReader()); - try { - tw.addTree(rw.parseTree(ref.getObjectId())); - tw.setRecursive(true); - while (tw.next()) { - if (tw.getFileMode(0) == FileMode.REGULAR_FILE) { - try { - list.add(DashboardsCollection.parse( - definingProject, - ref.getName().substring(REFS_DASHBOARDS.length()), - tw.getPathString(), - new BlobBasedConfig(null, git, tw.getObjectId(0)), - project, - setDefault)); - } catch (ConfigInvalidException e) { - log.warn(String.format( - "Cannot parse dashboard %s:%s:%s: %s", - definingProject.getName(), ref.getName(), tw.getPathString(), - e.getMessage())); - } + tw.addTree(rw.parseTree(ref.getObjectId())); + tw.setRecursive(true); + while (tw.next()) { + if (tw.getFileMode(0) == FileMode.REGULAR_FILE) { + try { + list.add(DashboardsCollection.parse( + definingProject, + ref.getName().substring(REFS_DASHBOARDS.length()), + tw.getPathString(), + new BlobBasedConfig(null, git, tw.getObjectId(0)), + project, + setDefault)); + } catch (ConfigInvalidException e) { + log.warn(String.format( + "Cannot parse dashboard %s:%s:%s: %s", + definingProject.getName(), ref.getName(), tw.getPathString(), + e.getMessage())); } } - } finally { - tw.release(); } return list; }