opendev/gerrit
Code Issues Proposed changes

CommitMergeStatus: Make message member final

Browse Source 
Otherwise error prone complains about it [1]:

  enums should be immutable, and cannot have non-final fields

[1] http://errorprone.info/bugpattern/ImmutableEnumChecker

Bug: Issue 5823
Change-Id: I2c0570afd7d53b76305e7407d57cea741873de54
This commit is contained in:
David Pursehouse
2017-03-21 16:53:39 +09:00
parent b69e49c5cd
commit 169e1572ff
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/CommitMergeStatus.java
View File

@@ -62,7 +62,7 @@ public enum CommitMergeStatus {
+ "\n" + "\n"
+ "Please rebase the change locally and upload again for review."); + "Please rebase the change locally and upload again for review.");
private String message; private final String message;
CommitMergeStatus(String message) { CommitMergeStatus(String message) {
this.message = message; this.message = message;