opendev/gerrit
Code Issues Proposed changes

ChangeNotesState: Remove changeMessagesByPatchSet field

Browse Source 
The only caller outside of tests that used this field was
Submit#getConflictMessage, which no longer exists.

Rename the remaining field from allChangeMessages to changeMessages,
since there is no longer overlap with another name.

Change-Id: I8f2846d7b21b41a6e0c934fd73ff87f6dc8e58d9
This commit is contained in:
Dave Borowitz
2018-05-02 08:23:27 -04:00
parent cb67893742
commit 17625530b6
6 changed files with 15 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/server/notedb/ChangeNotes.java
View File

@@ -564,12 +564,7 @@ public class ChangeNotes extends AbstractChangeNotes<ChangeNotes> {
/** @return all change messages, in chronological order, oldest first. */
public ImmutableList<ChangeMessage> getChangeMessages() {
return state.allChangeMessages();
}
/** @return change messages by patch set, in chronological order, oldest first. */
public ImmutableListMultimap<PatchSet.Id, ChangeMessage> getChangeMessagesByPatchSet() {
return state.changeMessagesByPatchSet();
return state.changeMessages();
}
/** @return inline comments on each revision. */