opendev/gerrit
Code Issues Proposed changes

DefaultRefFilter: check ProjectState readable before checking "READ" permission

Browse Source 
Change-Id: I0a5f3dd5fb0bb2ddf47abc72a840c68ef088c60c
This commit is contained in:
Changcheng Xiao
2018-03-26 11:15:03 +02:00
committed by xchangcheng
parent 8d99576d47
commit 179ce3726b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/permissions/DefaultRefFilter.java
View File

@@ -114,7 +114,8 @@ class DefaultRefFilter {
PermissionBackend.WithUser withUser = permissionBackend.user(user); PermissionBackend.WithUser withUser = permissionBackend.user(user);
PermissionBackend.ForProject forProject = withUser.project(projectState.getNameKey()); PermissionBackend.ForProject forProject = withUser.project(projectState.getNameKey());
if (!projectState.isAllUsers()) { if (!projectState.isAllUsers()) {
if (checkProjectPermission(forProject, ProjectPermission.READ)) { if (projectState.statePermitsRead()
&& checkProjectPermission(forProject, ProjectPermission.READ)) {
return refs; return refs;
} else if (projectControl.allRefsAreVisible(ImmutableSet.of(RefNames.REFS_CONFIG))) { } else if (projectControl.allRefsAreVisible(ImmutableSet.of(RefNames.REFS_CONFIG))) {
return fastHideRefsMetaConfig(refs); return fastHideRefsMetaConfig(refs);