opendev/gerrit
Code Issues Proposed changes

DeleteRef: Pass project name into validateRefOperation

Browse Source 
The expected parameter is a project name, not a ref name:

[2017-03-21 09:46:36,883] [SyncHook-2] ERROR com.googlesource.gerrit.plugins.hooks.HookTask :
Error running hook ../hooks/ref-update
org.eclipse.jgit.errors.RepositoryNotFoundException: repository not found: ../git/refs/heads/test
    at com.google.gerrit.server.git.LocalDiskRepositoryManager.openRepository(LocalDiskRepositoryManager.java:157)
    at com.google.gerrit.server.git.LocalDiskRepositoryManager.openRepository(LocalDiskRepositoryManager.java:139)
    at com.googlesource.gerrit.plugins.hooks.HookTask.runHook(HookTask.java:102)
    at com.googlesource.gerrit.plugins.hooks.HookTask$Sync.call(HookTask.java:63)
    at com.googlesource.gerrit.plugins.hooks.HookTask$Sync.call(HookTask.java:1)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

Change-Id: I128801b13c1fc6150a52393b2309586c19b1446e
This commit is contained in:
David Pursehouse
2017-03-21 09:56:12 +09:00
parent fb9b741a5a
commit 17d85f12fd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/project/DeleteRef.java
View File

@@ -118,7 +118,7 @@ public class DeleteRef {
u.setExpectedOldObjectId(r.exactRef(ref).getObjectId());
u.setNewObjectId(ObjectId.zeroId());
u.setForceUpdate(true);
refDeletionValidator.validateRefOperation(ref, identifiedUser.get(), u);
refDeletionValidator.validateRefOperation(resource.getName(), identifiedUser.get(), u);
int remainingLockFailureCalls = MAX_LOCK_FAILURE_CALLS;
for (; ; ) {
try {