opendev/gerrit
Code Issues Proposed changes

Show added assignee even if user hasn't specified full name

Browse Source 
If assignee has no full name or email, display anonymous coward name.

Change-Id: Ib4ea6d6b54f9e516861d517356f14e2d1adb6099
This commit is contained in:
Sven Selberg
2016-10-06 10:30:41 +02:00
parent 7162c299b4
commit 18c8721bb4
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java
View File

@@ -15,6 +15,7 @@
package com.google.gerrit.client.change;
import com.google.gerrit.client.FormatUtil;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.NotSignedInDialog;
import com.google.gerrit.client.changes.ChangeApi;
import com.google.gerrit.client.changes.Util;
@@ -186,7 +187,7 @@ public class Assignee extends Composite {
private void setAssignee(AccountInfo assignee) {
currentAssignee = assignee;
assigneeLink.setText(assignee != null ? assignee.name() : null);
assigneeLink.setText(assignee != null ? getName(assignee) : null);
assigneeLink.setTargetHistoryToken(assignee != null
? PageLinks.toAssigneeQuery(assignee.name() != null
? assignee.name()
@@ -207,4 +208,14 @@ public class Assignee extends Composite {
}
return null;
}
private String getName(AccountInfo info) {
if (info.name() != null) {
return info.name();
}
if (info.email() != null) {
return info.email();
}
return Gerrit.info().user().anonymousCowardName();
}
}