opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.15' into stable-2.16

Browse Source 
* stable-2.15:
  ReceiveCommits: Fix setting [PRIVATE] and [WIP] for updated changes
  ElasticContainer: Use 6.5.3 for V6_5 tests
  Upgrade elasticsearch-rest-client to 6.5.3

Change-Id: Id5acbce5a12a681856b95f9e160a83552046c5bb
This commit is contained in:
David Pursehouse
2018-12-14 08:29:19 +09:00
parent 5737db9dbc 11cfda8dff
commit 19b53a587e
3 changed files with 19 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
WORKSPACE
View File

@@ -1091,8 +1091,8 @@ maven_jar(
# and httpasyncclient as necessary.
maven_jar(
name = "elasticsearch-rest-client",
artifact = "org.elasticsearch.client:elasticsearch-rest-client:6.5.2",
sha1 = "6ad0dd15affe56be7dfe638fe317bc5f7456b730",
artifact = "org.elasticsearch.client:elasticsearch-rest-client:6.5.3",
sha1 = "ac8df46fce1c01b61cbf1f84186bf910d12b577e",
)
JACKSON_VERSION = "2.9.7"

41
java/com/google/gerrit/server/git/receive/ReceiveCommits.java
View File

@@ -728,8 +728,23 @@ class ReceiveCommits {
addMessage("");
addMessage("Updated Changes:");
boolean edit = magicBranch != null && (magicBranch.edit || magicBranch.draft);
Boolean isPrivate = null;
Boolean wip = null;
for (ReplaceRequest u : updated) {
String subject;
Change change = u.notes.getChange();
if (edit) {
try {
subject = receivePack.getRevWalk().parseCommit(u.newCommitId).getShortMessage();
} catch (IOException e) {
// Log and fall back to original change subject
logger.atWarning().withCause(e).log("failed to get subject for edit patch set");
subject = change.getSubject();
}
} else {
subject = u.info.getSubject();
}
boolean isPrivate = change.isPrivate();
boolean wip = change.isWorkInProgress();
if (magicBranch != null) {
if (magicBranch.isPrivate) {
isPrivate = true;
@@ -742,30 +757,10 @@ class ReceiveCommits {
wip = false;
}
}
for (ReplaceRequest u : updated) {
String subject;
if (edit) {
try {
subject = receivePack.getRevWalk().parseCommit(u.newCommitId).getShortMessage();
} catch (IOException e) {
// Log and fall back to original change subject
logger.atWarning().withCause(e).log("failed to get subject for edit patch set");
subject = u.notes.getChange().getSubject();
}
} else {
subject = u.info.getSubject();
}
if (isPrivate == null) {
isPrivate = u.notes.getChange().isPrivate();
}
if (wip == null) {
wip = u.notes.getChange().isWorkInProgress();
}
ChangeReportFormatter.Input input =
ChangeReportFormatter.Input.builder()
.setChange(u.notes.getChange())
.setChange(change)
.setSubject(subject)
.setIsEdit(edit)
.setIsPrivate(isPrivate)

2
javatests/com/google/gerrit/elasticsearch/ElasticContainer.java
View File

@@ -45,7 +45,7 @@ public class ElasticContainer extends ElasticsearchContainer {
case V6_4:
return "docker.elastic.co/elasticsearch/elasticsearch-oss:6.4.3";
case V6_5:
return "docker.elastic.co/elasticsearch/elasticsearch-oss:6.5.2";
return "docker.elastic.co/elasticsearch/elasticsearch-oss:6.5.3";
case V7_0:
return "docker.elastic.co/elasticsearch/elasticsearch-oss:7.0.0-alpha1";
}