opendev/gerrit
Code Issues Proposed changes

Bazel: Gracefully ignore eclipse-out directory

Browse Source 
Bazel doesn't provide a way to exclude scanning directories in project
root: [1]. Add workaround, by teaching Eclipse to exclude BUILD file
instead. With this workaround in place Eclipse and Bazel build can
co-exist:

  $ tools/eclipse/project.py # generates .classpath and other files
  # Start Eclipse and rebuild gerrit, eclipse-out is created
  $ bazel test ... # works as expected now

[1] https://github.com/bazelbuild/bazel/issues/1083

Change-Id: I7e767d0768af8bba3acc84d5fc242cab0e9abfdb
This commit is contained in:
David Ostrovsky 2016-10-30 08:32:43 +01:00
parent 67ae28a2a2
commit 19b60b5527
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/eclipse/project.py
View File

@ -80,14 +80,14 @@ def gen_plugin_classpath(root):
with open(p, 'w') as fd:
if path.exists(path.join(root, 'src', 'test', 'java')):
testpath = """
<classpathentry kind="src" path="src/test/java"\
<classpathentry excluding="**/BUILD" kind="src" path="src/test/java"\
out="eclipse-out/test"/>"""
else:
testpath = ""
print("""\
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="src/main/java"/>%(testpath)s
<classpathentry excluding="**/BUILD" kind="src" path="src/main/java"/>%(testpath)s
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry combineaccessrules="false" kind="src" path="/gerrit"/>
<classpathentry kind="output" path="eclipse-out/classes"/>
@ -101,6 +101,11 @@ def gen_classpath():
def classpathentry(kind, path, src=None, out=None, exported=None):
e = doc.createElement('classpathentry')
e.setAttribute('kind', kind)
# TODO(davido): Remove this and other exclude BUILD files hack
# when this Bazel bug is fixed:
# https://github.com/bazelbuild/bazel/issues/1083
if kind == 'src':
e.setAttribute('excluding', '**/BUILD')
e.setAttribute('path', path)
if src:
e.setAttribute('sourcepath', src)