Merge "Make sure status chip tooltip text gets updated"

polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.js

@@ -37,18 +37,12 @@
         type: String,
         observer: '_updateChipDetails',
       },
-      tooltipText: String,
-      hasTooltip: {
-        type: Boolean,
-        reflectToAttribute: true,
-        computed: '_determineHasTooltip(title)',
+      tooltipText: {
+        type: String,
+        value: '',
       },
     },
 
-    _determineHasTooltip(title) {
-      return !!title;
-    },
-
     _computeStatusString(status) {
       if (status === ChangeStates.WIP) {
         return 'Work in Progress';
@@ -73,6 +67,9 @@
         case ChangeStates.PRIVATE:
           this.tooltipText = PRIVATE_TOOLTIP;
           break;
+        default:
+          this.tooltipText = '';
+          break;
       }
     },
   });

polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status_test.html

@@ -55,21 +55,21 @@ limitations under the License.
     test('merged', () => {
       element.status = 'Merged';
       assert.equal(element.$$('.chip').innerText, element.status);
-      assert.isUndefined(element.tooltipText);
+      assert.equal(element.tooltipText, '');
       assert.isTrue(element.classList.contains('merged'));
     });
 
     test('abandoned', () => {
       element.status = 'Abandoned';
       assert.equal(element.$$('.chip').innerText, element.status);
-      assert.isUndefined(element.tooltipText);
+      assert.equal(element.tooltipText, '');
       assert.isTrue(element.classList.contains('abandoned'));
     });
 
     test('merge conflict', () => {
       element.status = 'Merge Conflict';
       assert.equal(element.$$('.chip').innerText, element.status);
-      assert.isUndefined(element.tooltipText);
+      assert.equal(element.tooltipText, '');
       assert.isTrue(element.classList.contains('merge-conflict'));
     });
 
@@ -83,14 +83,14 @@ limitations under the License.
     test('active', () => {
       element.status = 'Active';
       assert.equal(element.$$('.chip').innerText, element.status);
-      assert.isUndefined(element.tooltipText);
+      assert.equal(element.tooltipText, '');
       assert.isTrue(element.classList.contains('active'));
     });
 
     test('ready to submit', () => {
       element.status = 'Ready to submit';
       assert.equal(element.$$('.chip').innerText, element.status);
-      assert.isUndefined(element.tooltipText);
+      assert.equal(element.tooltipText, '');
       assert.isTrue(element.classList.contains('ready-to-submit'));
     });