opendev/gerrit
Code Issues Proposed changes

Fix hashtag display

Browse Source 
This updates gr-limited-text to handle cases where there is no limit
provided. Previously, the parent element handled this case in a dom-if,
however, the dom-if was not evaluated because the value was undefined.

Change-Id: Iae598c6afe4be7ca1fe96a2baf02ec13629bd962
This commit is contained in:
Becky Siegel
2017-09-25 15:44:43 -07:00
parent c88e961847
commit 1a08f61a52
3 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.html
View File

@@ -63,14 +63,9 @@ limitations under the License.
}
</style>
<div class$="container [[_getBackgroundClass(transparentBackground)]]">
<template is="dom-if" if="[[limit]]">
<a href$="[[href]]">
<gr-limited-text limit="[[limit]]" text="[[text]]"></gr-limited-text>
</a>
</template>
<template is="dom-if" if="[[!limit]]">
<a href$="[[href]]">[[text]]</a>
</template>
<a href$="[[href]]">
<gr-limited-text limit="[[limit]]" text="[[text]]"></gr-limited-text>
</a>
<gr-button
id="remove"
hidden$="[[!removable]]"