Fix hashtag display

This updates gr-limited-text to handle cases where there is no limit
provided. Previously, the parent element handled this case in a dom-if,
however, the dom-if was not evaluated because the value was undefined.

Change-Id: Iae598c6afe4be7ca1fe96a2baf02ec13629bd962

polygerrit-ui/app/elements/shared/gr-limited-text/gr-limited-text.js

@@ -29,7 +29,10 @@
       text: String,
 
       /** The maximum length for the text to display before truncating. */
-      limit: Number,
+      limit: {
+        type: Number,
+        value: null,
+      },
 
       /** Boolean property used by Gerrit.TooltipBehavior. */
       hasTooltip: {
@@ -51,7 +54,7 @@
      * enabled.
      */
     _updateTitle(text, limit) {
-      this.hasTooltip = text.length > limit;
+      this.hasTooltip = !!limit && text.length > limit;
       if (this.hasTooltip) {
         this.setAttribute('title', text);
       } else {
@@ -60,7 +63,7 @@
     },
 
     _computeDisplayText(text, limit) {
-      if (text.length > limit) {
+      if (!!limit && text.length > limit) {
         return text.substr(0, limit - 1) + '…';
       }
       return text;

polygerrit-ui/app/elements/shared/gr-limited-text/gr-limited-text_test.html

@@ -50,25 +50,31 @@ limitations under the License.
       const updateSpy = sandbox.spy(element, '_updateTitle');
       element.text = 'abc 123';
       flushAsynchronousOperations();
-      assert.isFalse(updateSpy.called);
+      assert.isTrue(updateSpy.calledOnce);
       assert.isNotOk(element.getAttribute('title'));
       assert.isFalse(element.hasTooltip);
 
       element.limit = 10;
       flushAsynchronousOperations();
-      assert.isTrue(updateSpy.calledOnce);
+      assert.isTrue(updateSpy.calledTwice);
       assert.isNotOk(element.getAttribute('title'));
       assert.isFalse(element.hasTooltip);
 
       element.limit = 3;
       flushAsynchronousOperations();
-      assert.isTrue(updateSpy.calledTwice);
+      assert.isTrue(updateSpy.calledThrice);
       assert.equal(element.getAttribute('title'), 'abc 123');
       assert.isTrue(element.hasTooltip);
 
       element.limit = 100;
       flushAsynchronousOperations();
-      assert.isTrue(updateSpy.calledThrice);
+      assert.equal(updateSpy.callCount, 4);
+      assert.isNotOk(element.getAttribute('title'));
+      assert.isFalse(element.hasTooltip);
+
+      element.limit = null;
+      flushAsynchronousOperations();
+      assert.equal(updateSpy.callCount, 5);
       assert.isNotOk(element.getAttribute('title'));
       assert.isFalse(element.hasTooltip);
     });
@@ -76,6 +82,7 @@ limitations under the License.
     test('_computeDisplayText', () => {
       assert.equal(element._computeDisplayText('foo bar', 100), 'foo bar');
       assert.equal(element._computeDisplayText('foo bar', 4), 'foo…');
+      assert.equal(element._computeDisplayText('foo bar', null), 'foo bar');
     });
   });
 </script>

polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.html

@@ -63,14 +63,9 @@ limitations under the License.
       }
     </style>
     <div class$="container [[_getBackgroundClass(transparentBackground)]]">
-      <template is="dom-if" if="[[limit]]">
-        <a href$="[[href]]">
-          <gr-limited-text limit="[[limit]]" text="[[text]]"></gr-limited-text>
-        </a>
-      </template>
-      <template is="dom-if" if="[[!limit]]">
-        <a href$="[[href]]">[[text]]</a>
-      </template>
+      <a href$="[[href]]">
+        <gr-limited-text limit="[[limit]]" text="[[text]]"></gr-limited-text>
+      </a>
       <gr-button
           id="remove"
           hidden$="[[!removable]]"