opendev/gerrit
Code Issues Proposed changes

Improve inline comment location link alignment

Browse Source 
Inline comments in the message list are right-aligned in such a way that
the corresponding message bodies are left-aligned and easier to read.
Problematically, the length of the location link text could vary
dramatically, and if they exceed the given minimum horizontal space, the
list of comments can become misaligned.

Since switching to a proportionate-width font, the link could also be
approximately as long as the given minimum width, resulting in the
appearance of being left-aligned, causing other links look misaligned
when they are not.

With this change, the min-width for location links is expanded and they
are given more margin. This results in more consistent alignments across
the range of comment location link texts.

Bug: Issue 5174
Change-Id: I7f4509eb6a496a8927539642491807bf4898fac5
This commit is contained in:
Wyatt Allen
2017-01-11 15:43:25 -08:00
parent f125df6aa6
commit 1a43dbec90
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/change/gr-comment-list/gr-comment-list.html
View File

@@ -36,8 +36,8 @@ limitations under the License.
margin: 5px 0;
}
.lineNum {
margin-right: .35em;
min-width: 5em;
margin-right: .5em;
min-width: 10em;
text-align: right;
}
.message {