opendev/gerrit
Code Issues Proposed changes

InlineEdit: Add GET /changes/<id>/edit REST endpoint

Browse Source 
Add get REST endpoint to read details of change edit. Result is a
EditInfo JSON response or no content when edit doesn't exist for
this change.

Change-Id: I72969cea48b4b1f13154bfa93d403405bec37494
This commit is contained in:
David Ostrovsky
2014-07-29 00:40:02 +02:00
parent 7c51481994
commit 1a49f62750
7 changed files with 230 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeEdits.java
View File

@@ -14,21 +14,37 @@
package com.google.gerrit.server.change;
import com.google.common.base.Optional;
import com.google.gerrit.extensions.common.EditInfo;
import com.google.gerrit.extensions.registration.DynamicMap;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.ChildCollection;
import com.google.gerrit.extensions.restapi.IdString;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
import com.google.gerrit.extensions.restapi.Response;
import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.extensions.restapi.RestView;
import com.google.gerrit.server.edit.ChangeEdit;
import com.google.gerrit.server.edit.ChangeEditJson;
import com.google.gerrit.server.edit.ChangeEditUtil;
import com.google.gerrit.server.project.InvalidChangeOperationException;
import com.google.gerrit.server.project.NoSuchChangeException;
import com.google.inject.Inject;
import com.google.inject.Singleton;
import java.io.IOException;
@Singleton
class ChangeEdits implements
ChildCollection<ChangeResource, ChangeEditResource> {
private final DynamicMap<RestView<ChangeEditResource>> views;
private final Detail detail;
@Inject
ChangeEdits(DynamicMap<RestView<ChangeEditResource>> views) {
ChangeEdits(DynamicMap<RestView<ChangeEditResource>> views,
Detail detail) {
this.views = views;
this.detail = detail;
}
@Override
@@ -38,11 +54,35 @@ class ChangeEdits implements
@Override
public RestView<ChangeResource> list() {
throw new IllegalStateException("not yet implemented");
return detail;
}
@Override
public ChangeEditResource parse(ChangeResource change, IdString id) {
throw new IllegalStateException("not yet implemented");
}
@Singleton
static class Detail implements RestReadView<ChangeResource> {
private final ChangeEditUtil editUtil;
private final ChangeEditJson editJson;
@Inject
Detail(ChangeEditJson editJson,
ChangeEditUtil editUtil) {
this.editJson = editJson;
this.editUtil = editUtil;
}
@Override
public Response<EditInfo> apply(ChangeResource rsrc) throws AuthException,
IOException, NoSuchChangeException, InvalidChangeOperationException,
ResourceNotFoundException {
Optional<ChangeEdit> edit = editUtil.byChange(rsrc.getChange());
if (edit.isPresent()) {
return Response.ok(editJson.toEditInfo(edit.get()));
}
return Response.none();
}
}
}