opendev/gerrit
Code Issues Proposed changes

Merge "Fix lint errors"

Browse Source
This commit is contained in:
Wyatt Allen 2018-04-06 17:18:39 +00:00 committed by Gerrit Code Review
commit 1a76324f14
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js
View File

@ -297,7 +297,8 @@
*/
_recursivelyRemoveDeleted(obj) {
for (const k in obj) {
if (!obj.hasOwnProperty(k)) { return; }
if (!obj.hasOwnProperty(k)) { continue; }
if (typeof obj[k] == 'object') {
if (obj[k].deleted) {
delete obj[k];
@ -310,7 +311,7 @@
_recursivelyUpdateAddRemoveObj(obj, addRemoveObj, path = []) {
for (const k in obj) {
if (!obj.hasOwnProperty(k)) { return; }
if (!obj.hasOwnProperty(k)) { continue; }
if (typeof obj[k] == 'object') {
const updatedId = obj[k].updatedId;
const ref = updatedId ? updatedId : k;

4
polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.js
View File

@ -132,9 +132,9 @@
// then hides the text box and submit button.
_computeHideAgreementClass(name, config) {
for (const key in config) {
if (!config.hasOwnProperty(key)) { return; }
if (!config.hasOwnProperty(key)) { continue; }
for (const prop in config[key]) {
if (!config[key].hasOwnProperty(prop)) { return; }
if (!config[key].hasOwnProperty(prop)) { continue; }
if (name === config[key].name &&
!config[key].auto_verify_group) {
return 'hideAgreementsTextBox';

1
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
View File

@ -189,6 +189,7 @@
const params = [];
for (const p in opt_params) {
if (!opt_params.hasOwnProperty(p)) { continue; }
if (opt_params[p] == null) {
params.push(encodeURIComponent(p));
continue;