opendev/gerrit
Code Issues Proposed changes

ChangeUpdate: Sanitize identity in Submitted-with footer

Browse Source 
We already sanitize names and emails elsewhere, but missed this one.

Change-Id: I55abb96504c9b9f5b7d8dc7f221fb27c4c5885c5
This commit is contained in:
Dave Borowitz
2016-10-05 10:14:52 -04:00
parent a9986eb1c0
commit 1ac31577b6
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeUpdate.java
View File

@@ -646,10 +646,8 @@ public class ChangeUpdate extends AbstractChangeUpdate {
addFooter(msg, FOOTER_SUBMITTED_WITH) addFooter(msg, FOOTER_SUBMITTED_WITH)
.append(label.status).append(": ").append(label.label); .append(label.status).append(": ").append(label.label);
if (label.appliedBy != null) { if (label.appliedBy != null) {
PersonIdent ident = msg.append(": ");
newIdent(accountCache.get(label.appliedBy).getAccount(), when); addIdent(msg, label.appliedBy);
msg.append(": ").append(ident.getName())
.append(" <").append(ident.getEmailAddress()).append('>');
} }
msg.append('\n'); msg.append('\n');
} }