opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Place draft comment icon to left of PS

Browse Source 
Show "[icon] 3" instead of "3 [icon]". This aligns the PS numbers
within their column and places the icons to the left, where they
don't skew the alignment.

Change-Id: Icd350581f6f478bf1acf4dd843524aca89324ecb
This commit is contained in:
Shawn Pearce
2013-10-10 12:58:48 -07:00
parent 41e7159a75
commit 1ac753a376
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RevisionsBox.java
View File

@@ -175,21 +175,20 @@ class RevisionsBox extends Composite {
sb.setStyleName(style.current());
}
sb.openTd()
.setStyleName(style.legacy_id())
.append(r._number());
sb.openTd().setStyleName(style.legacy_id());
if (r.draft()) {
sb.append(" ").append(Resources.C.draft());
sb.append(Resources.C.draft()).append(' ');
}
if (r.has_draft_comments()) {
sb.append(" ")
.openSpan()
.addStyleName(style.draft_comment())
.setAttribute("title", Resources.C.draftCommentsTooltip())
.append(new ImageResourceRenderer()
.render(Gerrit.RESOURCES.draftComments()))
.closeSpan();
sb.openSpan()
.addStyleName(style.draft_comment())
.setAttribute("title", Resources.C.draftCommentsTooltip())
.append(new ImageResourceRenderer()
.render(Gerrit.RESOURCES.draftComments()))
.closeSpan()
.append(' ');
}
sb.append(r._number());
sb.closeTd();
sb.openTd()