opendev/gerrit
Code Issues Proposed changes

Merge "Rename RetryingRestCollectionView to RetryingRestCollectionModifyView"

Browse Source
This commit is contained in:
Dave Borowitz 2018-07-20 16:52:21 +00:00 committed by Gerrit Code Review
commit 1ade4162e0
5 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/restapi/change/CreateChange.java
View File

@ -69,7 +69,7 @@ import com.google.gerrit.server.restapi.project.CommitsCollection;
import com.google.gerrit.server.restapi.project.ProjectsCollection;
import com.google.gerrit.server.update.BatchUpdate;
import com.google.gerrit.server.update.RetryHelper;
import com.google.gerrit.server.update.RetryingRestCollectionView;
import com.google.gerrit.server.update.RetryingRestCollectionModifyView;
import com.google.gerrit.server.update.UpdateException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
@ -98,7 +98,7 @@ import org.eclipse.jgit.util.ChangeIdUtil;
@Singleton
public class CreateChange
extends RetryingRestCollectionView<
extends RetryingRestCollectionModifyView<
TopLevelResource, ChangeResource, ChangeInput, Response<ChangeInfo>> {
private final String anonymousCowardName;
private final Provider<ReviewDb> db;

4
java/com/google/gerrit/server/restapi/change/PostReviewers.java
View File

@ -71,7 +71,7 @@ import com.google.gerrit.server.restapi.account.AccountsCollection;
import com.google.gerrit.server.restapi.group.GroupsCollection;
import com.google.gerrit.server.update.BatchUpdate;
import com.google.gerrit.server.update.RetryHelper;
import com.google.gerrit.server.update.RetryingRestCollectionView;
import com.google.gerrit.server.update.RetryingRestCollectionModifyView;
import com.google.gerrit.server.update.UpdateException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
@ -87,7 +87,7 @@ import org.eclipse.jgit.lib.Config;
@Singleton
public class PostReviewers
extends RetryingRestCollectionView<
extends RetryingRestCollectionModifyView<
ChangeResource, ReviewerResource, AddReviewerInput, AddReviewerResult> {
public static final int DEFAULT_MAX_REVIEWERS_WITHOUT_CHECK = 10;

4
java/com/google/gerrit/server/restapi/change/PublishChangeEdit.java
View File

@ -32,7 +32,7 @@ import com.google.gerrit.server.project.ContributorAgreementsChecker;
import com.google.gerrit.server.project.NoSuchProjectException;
import com.google.gerrit.server.update.BatchUpdate;
import com.google.gerrit.server.update.RetryHelper;
import com.google.gerrit.server.update.RetryingRestCollectionView;
import com.google.gerrit.server.update.RetryingRestCollectionModifyView;
import com.google.gerrit.server.update.UpdateException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
@ -70,7 +70,7 @@ public class PublishChangeEdit
@Singleton
public static class Publish
extends RetryingRestCollectionView<
extends RetryingRestCollectionModifyView<
ChangeResource, ChangeEditResource.Publish, PublishChangeEditInput, Response<?>> {
private final ChangeEditUtil editUtil;

4
java/com/google/gerrit/server/restapi/change/RebaseChangeEdit.java
View File

@ -32,7 +32,7 @@ import com.google.gerrit.server.permissions.PermissionBackendException;
import com.google.gerrit.server.project.InvalidChangeOperationException;
import com.google.gerrit.server.update.BatchUpdate;
import com.google.gerrit.server.update.RetryHelper;
import com.google.gerrit.server.update.RetryingRestCollectionView;
import com.google.gerrit.server.update.RetryingRestCollectionModifyView;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
import com.google.inject.Singleton;
@ -68,7 +68,7 @@ public class RebaseChangeEdit
@Singleton
public static class Rebase
extends RetryingRestCollectionView<
extends RetryingRestCollectionModifyView<
ChangeResource, ChangeEditResource.Rebase, Input, Response<?>> {
private final GitRepositoryManager repositoryManager;
private final ChangeEditModifier editModifier;

4
java/com/google/gerrit/server/update/RetryingRestCollectionView.java → java/com/google/gerrit/server/update/RetryingRestCollectionModifyView.java
View File

@ -20,12 +20,12 @@ import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestCollectionModifyView;
import com.google.gerrit.extensions.restapi.RestResource;
public abstract class RetryingRestCollectionView<
public abstract class RetryingRestCollectionModifyView<
P extends RestResource, C extends RestResource, I, O>
implements RestCollectionModifyView<P, C, I> {
private final RetryHelper retryHelper;
protected RetryingRestCollectionView(RetryHelper retryHelper) {
protected RetryingRestCollectionModifyView(RetryHelper retryHelper) {
this.retryHelper = retryHelper;
}