diff --git a/gerrit-gwtui/BUCK b/gerrit-gwtui/BUCK index 90fdcab36c..ead19f4d5b 100644 --- a/gerrit-gwtui/BUCK +++ b/gerrit-gwtui/BUCK @@ -1,7 +1,7 @@ include_defs('//gerrit-gwtui/gwt.defs') include_defs('//tools/gwt-constants.defs') -DEPS = [ +DEPS = GWT_TRANSITIVE_DEPS + [ '//gerrit-gwtexpui:CSS', '//lib:gwtjsonrpc', '//lib/gwt:dev', diff --git a/gerrit-plugin-gwtui/BUCK b/gerrit-plugin-gwtui/BUCK index ec5903ac54..2ee0e19f26 100644 --- a/gerrit-plugin-gwtui/BUCK +++ b/gerrit-plugin-gwtui/BUCK @@ -55,7 +55,7 @@ java_doc( deps = DEPS + [ '//lib:gwtjsonrpc', '//lib:gwtorm_client', - '//lib/gwt:dev__jar', + '//lib/gwt:dev', '//gerrit-gwtui-common:client-lib', '//gerrit-common:client', '//gerrit-reviewdb:client', diff --git a/lib/gwt/BUCK b/lib/gwt/BUCK index 3e2f4115e0..6876dfe52e 100644 --- a/lib/gwt/BUCK +++ b/lib/gwt/BUCK @@ -15,15 +15,6 @@ maven_jar( id = 'com.google.gwt:gwt-dev:' + VERSION, sha1 = 'c2c3dd5baf648a0bb199047a818be5e560f48982', license = 'Apache2.0', - exported_deps = [ - ':javax-validation', - ':javax-validation_src', - '//lib/ow2:ow2-asm', - '//lib/ow2:ow2-asm-analysis', - '//lib/ow2:ow2-asm-commons', - '//lib/ow2:ow2-asm-tree', - '//lib/ow2:ow2-asm-util', - ], attach_source = False, exclude = ['org/eclipse/jetty/*'], ) @@ -34,7 +25,7 @@ maven_jar( bin_sha1 = 'b6bd7f9d78f6fdaa3c37dae18a4bd298915f328e', src_sha1 = '7a561191db2203550fbfa40d534d4997624cd369', license = 'Apache2.0', - visibility = [], + visibility = ['PUBLIC'], ) maven_jar( @@ -54,5 +45,5 @@ maven_jar( id = 'org.javassist:javassist:3.18.1-GA', sha1 = 'd9a09f7732226af26bf99f19e2cffe0ae219db5b', license = 'Apache2.0', - visibility = [], + visibility = ['PUBLIC'], ) diff --git a/tools/default.defs b/tools/default.defs index 543bf989e2..22cf388506 100644 --- a/tools/default.defs +++ b/tools/default.defs @@ -193,7 +193,7 @@ def gerrit_plugin( gwt_binary( name = name + '__gwt_application', modules = [gwt_module], - deps = GWT_PLUGIN_DEPS + ['//lib/gwt:dev'], + deps = GWT_PLUGIN_DEPS + GWT_TRANSITIVE_DEPS + ['//lib/gwt:dev'], module_deps = [':%s__gwt_module' % name], local_workers = cpu_count(), strict = True, diff --git a/tools/gwt-constants.defs b/tools/gwt-constants.defs index 2584f2d87d..8bafddb133 100644 --- a/tools/gwt-constants.defs +++ b/tools/gwt-constants.defs @@ -12,3 +12,13 @@ GWT_PLUGIN_DEPS = [ '//gerrit-plugin-gwtui:gwtui-api-lib', '//lib/gwt:user', ] + +GWT_TRANSITIVE_DEPS = [ + '//lib/gwt:javax-validation', + '//lib/gwt:javax-validation_src', + '//lib/ow2:ow2-asm', + '//lib/ow2:ow2-asm-analysis', + '//lib/ow2:ow2-asm-commons', + '//lib/ow2:ow2-asm-tree', + '//lib/ow2:ow2-asm-util', +]