opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.16'

Browse Source 
* stable-2.16:
  Mark support for git protocol v2 as experimental
  GroupsUpdate#updateCachesOnGroupCreation: Use forEach
  Set version to 2.16.2-SNAPSHOT

Change-Id: I5d19e159e79a0eb65b75429aefee832a866520bb
This commit is contained in:
David Pursehouse
2018-12-18 08:09:11 +09:00
parent 7099b708b4 7402f7a62b
commit 1b0c4f0843
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/config-gerrit.txt
View File

@@ -3609,6 +3609,10 @@ default behavior.
[[receive.enableProtocolV2]]receive.enableProtocolV2:: [[receive.enableProtocolV2]]receive.enableProtocolV2::
+ +
[NOTE]
Support for Git protocol version 2 is still experimental. Do not use it in
production!
+
Enable support for git protocol version 2. Enable support for git protocol version 2.
+ +
When this option is enabled, clients may send upload pack using git When this option is enabled, clients may send upload pack using git

8
java/com/google/gerrit/server/group/db/GroupsUpdate.java
View File

@@ -346,12 +346,8 @@ public class GroupsUpdate {
private void updateCachesOnGroupCreation(InternalGroup createdGroup) throws IOException { private void updateCachesOnGroupCreation(InternalGroup createdGroup) throws IOException {
indexer.get().index(createdGroup.getGroupUUID()); indexer.get().index(createdGroup.getGroupUUID());
for (Account.Id modifiedMember : createdGroup.getMembers()) { createdGroup.getMembers().forEach(groupIncludeCache::evictGroupsWithMember);
groupIncludeCache.evictGroupsWithMember(modifiedMember); createdGroup.getSubgroups().forEach(groupIncludeCache::evictParentGroupsOf);
}
for (AccountGroup.UUID modifiedSubgroup : createdGroup.getSubgroups()) {
groupIncludeCache.evictParentGroupsOf(modifiedSubgroup);
}
} }
private void updateCachesOnGroupUpdate(UpdateResult result) throws IOException { private void updateCachesOnGroupUpdate(UpdateResult result) throws IOException {