opendev/gerrit
Code Issues Proposed changes

Merge "Handle null reviewer input in PostReviewers"

Browse Source
This commit is contained in:
Edwin Kempin
2013-03-06 07:19:50 +00:00
committed by Gerrit Code Review
parent 0a3d777cee 73cb38bac5
commit 1bd5e6a125
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReviewers.java
View File

@@ -27,6 +27,7 @@ import com.google.gerrit.common.data.LabelTypes;
import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.common.errors.EmailException;
import com.google.gerrit.common.errors.NoSuchGroupException; import com.google.gerrit.common.errors.NoSuchGroupException;
import com.google.gerrit.extensions.restapi.AuthException; import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.BadRequestException;
import com.google.gerrit.extensions.restapi.DefaultInput; import com.google.gerrit.extensions.restapi.DefaultInput;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException; import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
import com.google.gerrit.extensions.restapi.RestModifyView; import com.google.gerrit.extensions.restapi.RestModifyView;
@@ -124,8 +125,11 @@ public class PostReviewers implements RestModifyView<ChangeResource, Input> {
@Override @Override
public PostResult apply(ChangeResource rsrc, Input input) public PostResult apply(ChangeResource rsrc, Input input)
throws ResourceNotFoundException, AuthException, OrmException, throws BadRequestException, ResourceNotFoundException, AuthException,
EmailException { OrmException, EmailException {
if (input.reviewer == null) {
throw new BadRequestException("missing reviewer field");
}
Account.Id accountId = parser.parse(rsrc, input.reviewer); Account.Id accountId = parser.parse(rsrc, input.reviewer);
try { try {
if (accountId != null) { if (accountId != null) {