opendev/gerrit
Code Issues Proposed changes

Add prominent link to repo browser from project listing page.

Browse Source 
Change-Id: Iddf61bd56c514c51436c41d8da7f59d1acf0f893
This commit is contained in:
Chad Horohoe 2012-08-16 16:15:22 -04:00 committed by Edwin Kempin
parent 80bf078f6a
commit 1bf67f4728
4 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.java
View File

@ -50,6 +50,7 @@ public interface AdminConstants extends Constants {
String buttonBrowseProjects();
String projects();
String projectRepoBrowser();
String headingGroupUUID();
String headingOwner();
String headingDescription();

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties
View File

@ -19,6 +19,7 @@ checkBoxEmptyCommit = Create initial empty commit
checkBoxPermissionsOnly = Only serve as parent for other projects
buttonBrowseProjects = Browse
projects = All projects
projectRepoBrowser = Repository Browser
useContentMerge = Automatically resolve conflicts
useContributorAgreements = Require a valid contributor agreement to upload
useSignedOffBy = Require <a href="http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by" target="_blank"><code>Signed-off-by</code></a> in commit message

27
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
View File

@ -15,6 +15,8 @@
package com.google.gerrit.client.admin;
import com.google.gerrit.client.Dispatcher;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.GitwebLink;
import com.google.gerrit.client.projects.ProjectInfo;
import com.google.gerrit.client.projects.ProjectMap;
import com.google.gerrit.client.rpc.ScreenLoadCallback;
@ -23,6 +25,7 @@ import com.google.gerrit.client.ui.ProjectsTable;
import com.google.gerrit.client.ui.Screen;
import com.google.gerrit.common.PageLinks;
import com.google.gwt.user.client.History;
import com.google.gwt.user.client.ui.Anchor;
public class ProjectListScreen extends Screen {
private ProjectsTable projects;
@ -45,6 +48,16 @@ public class ProjectListScreen extends Screen {
setPageTitle(Util.C.projectListTitle());
projects = new ProjectsTable() {
@Override
protected void initColumnHeaders() {
super.initColumnHeaders();
if (Gerrit.getGitwebLink() != null) {
table.setText(0, 3, Util.C.projectRepoBrowser());
table.getFlexCellFormatter().
addStyleName(0, 3, Gerrit.RESOURCES.css().dataHeader());
}
}
@Override
protected void onOpenRow(final int row) {
History.newItem(link(getRowItem(row)));
@ -54,10 +67,24 @@ public class ProjectListScreen extends Screen {
return Dispatcher.toProjectAdmin(item.name_key(), ProjectScreen.INFO);
}
@Override
protected void insert(int row, ProjectInfo k) {
super.insert(row, k);
if (Gerrit.getGitwebLink() != null) {
table.getFlexCellFormatter().
addStyleName(row, 3, Gerrit.RESOURCES.css().dataCell());
}
}
@Override
protected void populate(final int row, final ProjectInfo k) {
table.setWidget(row, 1, new Hyperlink(k.name(), link(k)));
table.setText(row, 2, k.description());
GitwebLink l = Gerrit.getGitwebLink();
if (l != null) {
table.setWidget(row, 3, new Anchor(l.getLinkName(), false, l.toProject(k
.name_key())));
}
setRowItem(row, k);
}

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ProjectsTable.java
View File

@ -35,7 +35,10 @@ public class ProjectsTable extends NavigationTable<ProjectInfo> {
keysNavigation.add(new OpenKeyCommand(0, 'o', Util.C.projectListOpen()));
keysNavigation.add(new OpenKeyCommand(0, KeyCodes.KEY_ENTER,
Util.C.projectListOpen()));
initColumnHeaders();
}
protected void initColumnHeaders() {
table.setText(0, 1, Util.C.projectName());
table.setText(0, 2, Util.C.projectDescription());