opendev/gerrit
Code Issues Proposed changes

Remove duplication of JarEntry comparator

Browse Source 
Removed duplication of Comparator<JarEntry> in
the HttpPluginServlet, reducing the copy & paste
of the inner class in the code and improving
readability.

Change-Id: I71201779619435edac9ff70fa1fddd53fa80d373
This commit is contained in:
Luca Milanesio 2014-06-18 16:26:25 +01:00 committed by David Pursehouse
parent a975c4f695
commit 1c4770412b
1 changed files with 10 additions and 12 deletions

22
gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/HttpPluginServlet.java

@ -83,6 +83,13 @@ class HttpPluginServlet extends HttpServlet
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private static final Logger log private static final Logger log
= LoggerFactory.getLogger(HttpPluginServlet.class); = LoggerFactory.getLogger(HttpPluginServlet.class);
private static final Comparator<JarEntry> JAR_ENTRY_COMPARATOR_BY_NAME =
new Comparator<JarEntry>() {
@Override
public int compare(JarEntry a, JarEntry b) {
return a.getName().compareTo(b.getName());
}
};
private final MimeUtilFileTypeRegistry mimeUtil; private final MimeUtilFileTypeRegistry mimeUtil;
private final Provider<String> webUrl; private final Provider<String> webUrl;
@ -369,18 +376,9 @@ class HttpPluginServlet extends HttpServlet
} }
} }
} }
Collections.sort(cmds, new Comparator<JarEntry>() {
@Override Collections.sort(cmds, JAR_ENTRY_COMPARATOR_BY_NAME);
public int compare(JarEntry a, JarEntry b) { Collections.sort(docs, JAR_ENTRY_COMPARATOR_BY_NAME);
return a.getName().compareTo(b.getName());
}
});
Collections.sort(docs, new Comparator<JarEntry>() {
@Override
public int compare(JarEntry a, JarEntry b) {
return a.getName().compareTo(b.getName());
}
});
StringBuilder md = new StringBuilder(); StringBuilder md = new StringBuilder();
md.append(String.format("# Plugin %s #\n", pluginName)); md.append(String.format("# Plugin %s #\n", pluginName));