From 1c4a7ffc354b74f835f93405d113fa2e39b3fc1f Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 26 Jun 2015 16:25:03 +0900 Subject: [PATCH] AbstractSubmit, ActionsIT: Disable tests for submitWholeTopic Forcibly disabling submitWholeTopic in commit 462f4ac causes several acceptance tests to fail because they expect it to be enabled. Remove the submitWholeTopic configuration for those tests. Note that this patch should be reverted when stable-2.11 is merged up to master. Change-Id: I2d46a76516ae7f5fb41083db8c337ac8ecaa46ca --- .../gerrit/acceptance/rest/change/AbstractSubmit.java | 7 ------- .../google/gerrit/acceptance/rest/change/ActionsIT.java | 7 ------- 2 files changed, 14 deletions(-) diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java index dec3e6547d..ac3066c2e8 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java @@ -52,7 +52,6 @@ import com.google.gerrit.server.events.Event; import com.google.gerrit.server.notedb.ChangeNotes; import com.google.gerrit.server.project.ListBranches.BranchInfo; import com.google.gerrit.server.project.PutConfig; -import com.google.gerrit.testutil.ConfigSuite; import com.google.gson.reflect.TypeToken; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; @@ -63,7 +62,6 @@ import org.apache.http.HttpStatus; import org.eclipse.jgit.api.Git; import org.eclipse.jgit.api.errors.GitAPIException; import org.eclipse.jgit.diff.DiffFormatter; -import org.eclipse.jgit.lib.Config; import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.Ref; import org.eclipse.jgit.lib.Repository; @@ -81,11 +79,6 @@ import java.util.List; import java.util.Map; public abstract class AbstractSubmit extends AbstractDaemonTest { - @ConfigSuite.Config - public static Config submitWholeTopicEnabled() { - return submitWholeTopicEnabledConfig(); - } - private Map mergeResults; @Inject diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/ActionsIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/ActionsIT.java index afcd5d0397..acd096d929 100644 --- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/ActionsIT.java +++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/ActionsIT.java @@ -21,23 +21,16 @@ import com.google.gerrit.acceptance.PushOneCommit; import com.google.gerrit.acceptance.RestResponse; import com.google.gerrit.extensions.api.changes.ReviewInput; import com.google.gerrit.extensions.common.ActionInfo; -import com.google.gerrit.testutil.ConfigSuite; import com.google.gson.reflect.TypeToken; import org.apache.http.HttpStatus; import org.eclipse.jgit.api.errors.GitAPIException; -import org.eclipse.jgit.lib.Config; import org.junit.Test; import java.io.IOException; import java.util.Map; public class ActionsIT extends AbstractDaemonTest { - @ConfigSuite.Config - public static Config submitWholeTopicEnabled() { - return submitWholeTopicEnabledConfig(); - } - @Test public void revisionActionsOneChangePerTopicUnapproved() throws Exception { String changeId = createChangeWithTopic("foo1").getChangeId();