Change "Loading ..." to say "Working ..."
RPCs that are changing state, like publishing comments or submitting a change shouldn't say "Loading". There is more going on than just loading a response. Change the text to a more generic "Working". Change-Id: I1473ba91b77714f4ead949a750dcb18057e6932e
This commit is contained in:
@@ -81,7 +81,7 @@ public interface GerritConstants extends Constants {
|
||||
String searchHint();
|
||||
String searchButton();
|
||||
|
||||
String rpcStatusLoading();
|
||||
String rpcStatusWorking();
|
||||
|
||||
String sectionNavigation();
|
||||
String sectionActions();
|
||||
|
||||
@@ -64,7 +64,7 @@ menuDocumentationAccess = Access Controls
|
||||
searchHint = Change #, SHA-1, tr:id, owner:email or reviewer:email
|
||||
searchButton = Search
|
||||
|
||||
rpcStatusLoading = Loading ...
|
||||
rpcStatusWorking = Working ...
|
||||
|
||||
sectionNavigation = Navigation
|
||||
sectionActions = Actions
|
||||
|
||||
@@ -47,7 +47,7 @@ public class RpcStatus implements RpcStartHandler, RpcCompleteHandler {
|
||||
p.add(r);
|
||||
|
||||
loading = new InlineLabel();
|
||||
loading.setText(Gerrit.C.rpcStatusLoading());
|
||||
loading.setText(Gerrit.C.rpcStatusWorking());
|
||||
loading.setStyleName(Gerrit.RESOURCES.css().rpcStatus());
|
||||
loading.addStyleName(Gerrit.RESOURCES.css().rpcStatusLoading());
|
||||
loading.setVisible(false);
|
||||
|
||||
@@ -250,7 +250,7 @@ public class NewAgreementScreen extends AccountScreen {
|
||||
String url = cla.getAgreementUrl();
|
||||
if (url != null && url.length() > 0) {
|
||||
agreementGroup.setVisible(true);
|
||||
agreementHtml.setText(Gerrit.C.rpcStatusLoading());
|
||||
agreementHtml.setText(Gerrit.C.rpcStatusWorking());
|
||||
if (!url.startsWith("http:") && !url.startsWith("https:")) {
|
||||
url = GWT.getHostPageBaseURL() + url;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user