opendev/gerrit
Code Issues Proposed changes

Fix error log message in ReceiveCommits

Browse Source 
When the creation of one or more references fails ReceiveCommits fails
with 'internal server error' and writes the following error log:
"Only X of Y new change refs created in xxx; aborting"
The printed value for Y could be wrong since it didn't include the
replaceCount. As a result, a confusing message like
"Only 0 of 0 new change refs created in xxx; aborting"
could appear in the error log.

Change-Id: I3520cd3268d4f2156eabcdc10dc0ec88e5873222
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-10 13:52:29 +01:00
parent 3c09039dd3
commit 1ce4192380
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -679,7 +679,7 @@ public class ReceiveCommits {
reject(newChange, "internal server error");
log.error(String.format(
"Only %d of %d new change refs created in %s; aborting",
okToInsert, newChanges.size(), project.getName()));
okToInsert, replaceCount + newChanges.size(), project.getName()));
return;
}