From caa93d2e16b9e729f10cc6741b071bfe2b6d1ebc Mon Sep 17 00:00:00 2001
From: Kasper Nilsson <kaspern@google.com>
Date: Fri, 26 May 2017 13:20:35 -0700
Subject: [PATCH] Fix manual transpilation error

Also adds a regression test.

Bug: Issue 6315
Change-Id: Ib839834259085109ec297981bd99d6f48d36ce39
---
 .../change/gr-change-view/gr-change-view.js        |  7 +++----
 .../change/gr-change-view/gr-change-view_test.html | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
index 77c2ca08d4..05c6c684f7 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
@@ -481,7 +481,7 @@
             document.documentElement.scrollTop =
                 document.body.scrollTop = this.viewState.scrollTop;
           } else {
-            this._maybeScrollToMessage();
+            this._maybeScrollToMessage(window.location.hash);
           }
         }, 1);
       });
@@ -513,10 +513,9 @@
       this.viewState.numFilesShown = numFilesShown;
     },
 
-    _maybeScrollToMessage() {
+    _maybeScrollToMessage(hash) {
       const msgPrefix = '#message-';
-      const hash = window.location.hash;
-      if (hash.startsWith(msgPrefix) === 0) {
+      if (hash.startsWith(msgPrefix)) {
         this.$.messageList.scrollToMessage(hash.substr(msgPrefix.length));
       }
     },
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
index 7794cd67db..5847e732e8 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
@@ -1320,5 +1320,19 @@ limitations under the License.
             'header wip');
       });
     });
+
+    test('_maybeScrollToMessage', () => {
+      const scrollStub = sandbox.stub(element.$.messageList, 'scrollToMessage');
+
+      element._maybeScrollToMessage('');
+      assert.isFalse(scrollStub.called);
+
+      element._maybeScrollToMessage('message');
+      assert.isFalse(scrollStub.called);
+
+      element._maybeScrollToMessage('#message-TEST');
+      assert.isTrue(scrollStub.called);
+      assert.equal(scrollStub.lastCall.args[0], 'TEST');
+    });
   });
 </script>