opendev/gerrit
Code Issues Proposed changes

Fix Gitweb HTTP URL generation

Browse Source 
Gitweb was generating an invalid URL for HTTP.

Remove invalid p character from URL and require authentication if the
project is not visible to anonymous users.

Change-Id: I99d426c8a630a9f0abfc0f66a3978a9e6b2ad0b6
This commit is contained in:
Hector Oswaldo Caballero
2016-12-14 07:35:33 -05:00
parent 8140f0cb74
commit 1d0e90957f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitwebServlet.java
View File

@@ -232,7 +232,10 @@ class GitwebServlet extends HttpServlet {
p.print(" if (( $secure && $ENV{'SERVER_PORT'} != 443)\n");
p.print(" || (!$secure && $ENV{'SERVER_PORT'} != 80)\n");
p.print(" );\n");
p.print(" $http_url .= qq{$ENV{'GERRIT_CONTEXT_PATH'}p};\n");
p.print(" $http_url .= qq{$ENV{'GERRIT_CONTEXT_PATH'}};\n");
p.print(" $http_url .= qq{/a}\n");
p.print(" unless $ENV{'GERRIT_ANONYMOUS_READ'};\n");
p.print(" \n");
p.print(" push @git_base_url_list, $http_url;\n");
p.print("}\n");
@@ -542,7 +545,7 @@ class GitwebServlet extends HttpServlet {
env.set("HTTP_" + name.toUpperCase().replace('-', '_'), value);
}
env.set("GERRIT_CONTEXT_PATH", req.getContextPath() + "/");
env.set("GERRIT_CONTEXT_PATH", req.getContextPath());
env.set("GERRIT_PROJECT_NAME", project.getProject().getName());
env.set("GITWEB_PROJECTROOT",