opendev/gerrit
Code Issues Proposed changes

Merge "Revert "Fix reviewer and cc dialogs both opening""

Browse Source
This commit is contained in:
Logan Hanks
2017-11-09 00:26:16 +00:00
committed by Gerrit Code Review
parent 369ba1c2e7 c173cb444f
commit 1dacd25ff0
2 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js
View File

@@ -210,7 +210,6 @@
},
_onInputBlur() {
this._focused = false;
this.$.input.classList.toggle('warnUncommitted',
this.warnUncommitted && this.text.length && !this._focused);
// Needed so that --paper-input-container-input updated style is applied.

6
polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete_test.html
View File

@@ -461,10 +461,8 @@ limitations under the License.
test('enabled', () => {
element.warnUncommitted = true;
element.text = 'blah blah blah';
element._focused = true;
MockInteractions.blur(element.$.input);
assert.isTrue(inputClassList.contains('warnUncommitted'));
assert.isFalse(element._focused);
assert.equal(getComputedStyle(element.$.input.inputElement).color,
'rgb(255, 0, 0)');
MockInteractions.focus(element.$.input);
@@ -475,20 +473,16 @@ limitations under the License.
test('disabled', () => {
element.warnUncommitted = false;
element._focused = true;
element.text = 'blah blah blah';
MockInteractions.blur(element.$.input);
assert.isFalse(inputClassList.contains('warnUncommitted'));
assert.isFalse(element._focused);
});
test('no text', () => {
element.warnUncommitted = true;
element._focused = true;
element.text = '';
MockInteractions.blur(element.$.input);
assert.isFalse(inputClassList.contains('warnUncommitted'));
assert.isFalse(element._focused);
});
});
});