opendev/gerrit
Code Issues Proposed changes

Sort library JARs by last modified time

Browse Source 
Newer JARs should have more recent mtimes than older JARs that supply
the same classes. Try to favor the newer versions by sorting first
by mtime and then by name.

Bug: issue 1870
Change-Id: I783ab01c070914e02384413e0f5461a9c29a2a70
This commit is contained in:
Shawn Pearce
2013-04-25 14:01:04 -07:00
parent 39f16cbea0
commit 1de243566d
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/SiteLibraryBasedDataSourceProvider.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.pgm.util;
import com.google.common.primitives.Longs;
import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.config.SitePaths;
import com.google.gerrit.server.schema.DataSourceProvider;
@@ -66,6 +67,11 @@ public class SiteLibraryBasedDataSourceProvider extends DataSourceProvider {
Arrays.sort(jars, new Comparator<File>() {
@Override
public int compare(File a, File b) {
// Sort by reverse last-modified time so newer JARs are first.
int cmp = Longs.compare(b.lastModified(), a.lastModified());
if (cmp != 0) {
return cmp;
}
return a.getName().compareTo(b.getName());
}
});