opendev/gerrit
Code Issues Proposed changes

Use one-way binding in loading indicator for gr-change-view

Browse Source 
Also hide the changes via the hidden attribute upon initial load.
The evaluation of hidden$= will set it correctly.

Change-Id: I7d3207c622e03988da2c3020a2c698811b299f9a
This commit is contained in:
Andrew Bonventre 2016-01-11 20:48:23 -05:00
parent c05ef8a2a6
commit 1de642461b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/gr-change-list-view.html
View File

@ -56,8 +56,8 @@ limitations under the License.
params="[[_computeQueryParams(query, offset)]]" params="[[_computeQueryParams(query, offset)]]"
last-response="{{_changes}}" last-response="{{_changes}}"
loading="{{_loading}}"></gr-ajax> loading="{{_loading}}"></gr-ajax>
<div class="loading" hidden$="{{!_loading}}">Loading...</div> <div class="loading" hidden$="[[!_loading]]">Loading...</div>
<div hidden$="{{_loading}}"> <div hidden$="[[_loading]]" hidden>
<gr-change-list changes="{{_changes}}"></gr-change-list> <gr-change-list changes="{{_changes}}"></gr-change-list>
<nav> <nav>
<a href$="[[_computeNavLink(query, offset, -1)]]" <a href$="[[_computeNavLink(query, offset, -1)]]"