opendev/gerrit
Code Issues Proposed changes

ChangeJson: Only list increasing values as permitted post-submit

Browse Source 
Change-Id: Iddffea00e263007d1284fb0337474a9263d986fd
This commit is contained in:
Dave Borowitz
2016-11-15 18:20:26 -08:00
committed by Edwin Kempin
parent d7424d36b0
commit 1decb0499e
5 changed files with 65 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/AbstractDaemonTest.java
View File

@@ -20,6 +20,7 @@ import static com.google.gerrit.extensions.api.changes.SubmittedTogetherOption.N
import static com.google.gerrit.reviewdb.client.Patch.COMMIT_MSG;
import static com.google.gerrit.reviewdb.client.Patch.MERGE_LIST;
import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS;
import static java.util.stream.Collectors.toList;
import static org.eclipse.jgit.lib.Constants.HEAD;
import com.google.common.base.Strings;
@@ -139,6 +140,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.EnumSet;
import java.util.HashMap;
@@ -1148,4 +1150,18 @@ public abstract class AbstractDaemonTest {
grant(Permission.SUBMIT, project, "refs/for/refs/heads/*");
return cloneProject(project);
}
protected void assertPermitted(ChangeInfo info, String label,
Integer... expected) {
assertThat(info.permittedLabels).isNotNull();
Collection<String> strs = info.permittedLabels.get(label);
if (expected.length == 0) {
assertThat(strs).isNull();
} else {
assertThat(
strs.stream().map(s -> Integer.valueOf(s.trim()))
.collect(toList()))
.containsExactlyElementsIn(Arrays.asList(expected));
}
}
}