opendev/gerrit
Code Issues Proposed changes

Use MINA sshd library for key generation and export

Browse Source 
Since this feature request was implemented: [1], in this commit: [2],
we don't have to depend on JCraft JSch library for key generation and
export in OpenSSH format in tests.

Given that JSch cannot read private key material in OpenSSH format, use
RSA instead of elliptic curve algorithm and export the private key in
PKCS #8 format using Bouncy Castle library.

[1] https://issues.apache.org/jira/browse/SSHD-984
[2] 42df03db20

Change-Id: I9bb35ac5f18c2463705fa52e33dc67df82f480d8
This commit is contained in:
David Ostrovsky
2020-06-02 23:41:39 +02:00
committed by Patrick Hiesel
parent db785425ac
commit 1df3756259
6 changed files with 77 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java
View File

@@ -150,9 +150,9 @@ import com.google.gerrit.testing.FakeEmailSender.Message;
import com.google.gerrit.truth.NullAwareCorrespondence;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.jcraft.jsch.KeyPair;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.security.KeyPair;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;