opendev/gerrit
Code Issues Proposed changes

BuckPrologCompiler: Fix potential NPE

Browse Source 
File.list() can return null, so it's unsafe to use it as an iterator
in a for-loop.

Store the result of File.list() first and only iterate it when it's
not null.

Change-Id: I0ced67e5bb5bc588433cb6a03a6283f9b31cb649
This commit is contained in:
David Pursehouse
2015-03-20 14:39:36 +09:00
parent a57ae4a249
commit 1e2458a0ef
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/prolog/java/BuckPrologCompiler.java
View File

@@ -63,7 +63,11 @@ public class BuckPrologCompiler {
private static void add(JarOutputStream out, File classes, String prefix) private static void add(JarOutputStream out, File classes, String prefix)
throws IOException { throws IOException {
for (String name : classes.list()) { String[] list = classes.list();
if (list == null) {
return;
}
for (String name : list) {
File f = new File(classes, name); File f = new File(classes, name);
if (f.isDirectory()) { if (f.isDirectory()) {
add(out, f, prefix + name + "/"); add(out, f, prefix + name + "/");