opendev/gerrit
Code Issues Proposed changes

Added dashboard and change-list to embedded views

Browse Source 
Renamed change-diff-views to embed as the embedded html contains additional
elements.

Change-Id: I6d22f55ed91ca8496175b227dea43d12f88e97b4
This commit is contained in:
Thomas Shafer
2018-01-16 11:35:27 -08:00
parent ad7e6f0bc0
commit 1e5495ad6a
3 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/embed/change-diff-views.html → polygerrit-ui/app/embed/embed.html
View File

@@ -16,4 +16,6 @@ limitations under the License.
<link rel="import" href="../bower_components/polymer/polymer.html">
<link rel="import" href="../elements/change/gr-change-view/gr-change-view.html">
<link rel="import" href="../elements/diff/gr-diff-view/gr-diff-view.html">
<link rel="import" href="../elements/change-list/gr-dashboard-view/gr-dashboard-view.html">
<link rel="import" href="../elements/change-list/gr-change-list-view/gr-change-list-view.html">
<link rel="import" href="../styles/app-theme.html">

26
polygerrit-ui/app/embed/embed_test.html
View File

@@ -16,11 +16,11 @@ limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>change-diff-views-embed_test</title>
<title>embed_test</title>
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../polygerrit_ui/elements/change-diff-views.html"/>
<link rel="import" href="../polygerrit_ui/elements/embed.html"/>
<script>void(0);</script>
@@ -36,6 +36,18 @@ limitations under the License.
</template>
</test-fixture>
<test-fixture id="dashboard-view">
<template>
<gr-dashboard-view></gr-dashboard-view>
</template>
</test-fixture>
<test-fixture id="change-list-view">
<template>
<gr-change-list-view></gr-change-list-view>
</template>
</test-fixture>
<script>
suite('embed test', () => {
test('gr-change-view is embedded', () => {
@@ -47,5 +59,15 @@ limitations under the License.
const element = fixture('diff-view');
assert.equal(element.is, 'gr-diff-view');
});
test('dashboard-view is embedded', () => {
const element = fixture('dashboard-view');
assert.equal(element.is, 'gr-dashboard-view');
});
test('change-list-view is embedded', () => {
const element = fixture('change-list-view');
assert.equal(element.is, 'gr-change-list-view');
});
});
</script>