opendev/gerrit
Code Issues Proposed changes

ChangeInserter: always commit ChangeUpdate

Browse Source 
ChangeUpdate.commit() is by design a no-op if no updates were made to
the change, so no need to check before calling.

Change-Id: Ic7b657553e28c2f0ce81d48e06e0a9c9d430a0d9
This commit is contained in:
Dave Borowitz
2014-06-27 09:31:28 -07:00
parent f1e12c70af
commit 1e782e6a9c
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java
View File

@@ -191,9 +191,7 @@ public class ChangeInserter {
} finally { } finally {
db.rollback(); db.rollback();
} }
if (messageIsForChange()) {
update.commit(); update.commit();
}
CheckedFuture<?, IOException> f = mergeabilityChecker.newCheck() CheckedFuture<?, IOException> f = mergeabilityChecker.newCheck()
.addChange(change) .addChange(change)
.reindex() .reindex()