opendev/gerrit
Code Issues Proposed changes

Fix the References in InboundEmailRejectionSender

Browse Source 
In real world setups, the Message-Id header is surrounded by "<>".
Before this commit, we tried to add < and > around the Message-Id,
leading to "<<Message-Id@mail.com>>", which is invalid.

Change-Id: I0611142de270ee7977537cebd5c77af31a2f226f
This commit is contained in:
Maxime Guerreiro
2018-02-23 14:13:47 +01:00
parent a3c90c8bf9
commit 1efd6f6d84
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/mail/send/InboundEmailRejectionSender.java
View File

@@ -59,7 +59,7 @@ public class InboundEmailRejectionSender extends OutgoingEmail {
add(RecipientType.TO, to);
if (!threadId.isEmpty()) {
setHeader(MailHeader.REFERENCES.fieldName(), "<" + threadId + ">");
setHeader(MailHeader.REFERENCES.fieldName(), threadId);
}
}