opendev/gerrit
Code Issues Proposed changes

Fix creating comments on Firefox ESF

Browse Source 
Use the slot attribute instead of property - on browsers that do not have
native Shadow DOM support, the slot property does not exist and setting
it will be ignored.

Change-Id: Ifac4a48aba0847630990fef800e7f9d60f57c931
This commit is contained in:
Ole Rehmsen
2019-06-05 16:13:32 +02:00
parent bf5b328748
commit 1f00b4ee4a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js
View File

@@ -632,7 +632,7 @@
_createThreadElement(thread) { _createThreadElement(thread) {
const threadEl = document.createElement('gr-comment-thread'); const threadEl = document.createElement('gr-comment-thread');
threadEl.className = 'comment-thread'; threadEl.className = 'comment-thread';
threadEl.slot = `${thread.commentSide}-${thread.lineNum}`; threadEl.setAttribute('slot', `${thread.commentSide}-${thread.lineNum}`);
threadEl.comments = thread.comments; threadEl.comments = thread.comments;
threadEl.commentSide = thread.commentSide; threadEl.commentSide = thread.commentSide;
threadEl.isOnParent = !!thread.isOnParent; threadEl.isOnParent = !!thread.isOnParent;

2
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
View File

@@ -775,7 +775,7 @@
// that is okay because the first matching slot is used and the rest // that is okay because the first matching slot is used and the rest
// are ignored. // are ignored.
const slot = document.createElement('slot'); const slot = document.createElement('slot');
slot.name = threadEl.slot; slot.name = threadEl.getAttribute('slot');
Polymer.dom(threadGroupEl).appendChild(Gerrit.slotToContent(slot)); Polymer.dom(threadGroupEl).appendChild(Gerrit.slotToContent(slot));
} }
}); });