opendev/gerrit
Code Issues Proposed changes

Truth: Move export to runtime_deps

Browse Source 
There is no good reason why depending on //lib/truth should free
downstream libraries from needing a direct dep on //lib/guava or
//lib/junit. Exporting the deps was probably just oversight, since the
distinction between exports and runtime_deps in WORKSPACE is not
obvious, and there are probably other bad examples.

Change-Id: I1530106d642167eaa25222cc95c3996478728e15
This commit is contained in:
Dave Borowitz 2018-05-15 09:18:22 -07:00
parent 94fd307693
commit 1f0e48a727
15 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/acceptance/BUILD
View File

@ -76,6 +76,7 @@ java_library2(
"//java/com/google/gerrit/server/group/testing",
"//java/com/google/gerrit/server/project/testing:project-test-util",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib:jimfs",
"//lib/auto:auto-value",
"//lib/auto:auto-value-annotations",

1
java/com/google/gerrit/server/group/testing/BUILD
View File

@ -8,6 +8,7 @@ java_library(
"//java/com/google/gerrit/common:server",
"//java/com/google/gerrit/reviewdb:server",
"//java/com/google/gerrit/server",
"//lib:guava",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/truth",
],

2
java/com/google/gerrit/testing/BUILD
View File

@ -29,8 +29,10 @@ java_library(
"//java/com/google/gerrit/server/cache/mem",
"//java/com/google/gerrit/server/restapi",
"//java/com/google/gerrit/server/schema",
"//lib:guava",
"//lib:gwtorm",
"//lib:h2",
"//lib:junit",
"//lib/auto:auto-value",
"//lib/auto:auto-value-annotations",
"//lib/guice",

1
java/com/google/gerrit/truth/BUILD
View File

@ -4,6 +4,7 @@ java_library(
srcs = glob(["**/*.java"]),
visibility = ["//visibility:public"],
deps = [
"//lib:guava",
"//lib/truth",
],
)

2
javatests/com/google/gerrit/acceptance/rest/project/BUILD
View File

@ -18,6 +18,7 @@ java_library(
],
deps = [
"//java/com/google/gerrit/extensions:api",
"//lib:guava",
"//lib/truth",
],
)
@ -31,6 +32,7 @@ java_library(
"//java/com/google/gerrit/extensions:api",
"//java/com/google/gerrit/reviewdb:server",
"//java/com/google/gerrit/server",
"//lib:guava",
"//lib:gwtorm",
"//lib/truth",
],

1
javatests/com/google/gerrit/index/BUILD
View File

@ -9,6 +9,7 @@ junit_tests(
"//java/com/google/gerrit/index",
"//java/com/google/gerrit/index:query_exception",
"//java/com/google/gerrit/index:query_parser",
"//lib:guava",
"//lib:junit",
"//lib/antlr:java_runtime",
"//lib/jgit/org.eclipse.jgit:jgit",

1
javatests/com/google/gerrit/reviewdb/BUILD
View File

@ -7,6 +7,7 @@ junit_tests(
"//java/com/google/gerrit/reviewdb:client",
"//java/com/google/gerrit/server/project/testing:project-test-util",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib:gwtorm",
"//lib/truth",
],

3
javatests/com/google/gerrit/server/BUILD
View File

@ -12,6 +12,7 @@ java_library(
"//java/com/google/gerrit/extensions:api",
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/truth",
"//lib:guava",
"//lib/truth",
],
)
@ -52,6 +53,7 @@ junit_tests(
"//java/org/eclipse/jgit:server",
"//lib:grappa",
"//lib:gson",
"//lib:guava",
"//lib:guava-retrying",
"//lib:gwtorm",
"//lib:protobuf",
@ -61,6 +63,7 @@ junit_tests(
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/jgit/org.eclipse.jgit.junit:junit",
"//lib/truth",
"//lib/truth:truth-java8-extension",
"//proto:cache_java_proto",
],

1
javatests/com/google/gerrit/server/group/db/BUILD
View File

@ -16,6 +16,7 @@ junit_tests(
"//java/com/google/gerrit/server/group/testing",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//java/com/google/gerrit/truth",
"//lib:guava",
"//lib:gwtorm",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/jgit/org.eclipse.jgit.junit:junit",

1
javatests/com/google/gerrit/server/query/account/BUILD
View File

@ -15,6 +15,7 @@ java_library(
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/server/schema",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/truth",

2
javatests/com/google/gerrit/server/query/change/BUILD
View File

@ -19,6 +19,7 @@ java_library(
"//java/com/google/gerrit/server/project/testing:project-test-util",
"//java/com/google/gerrit/server/schema",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib:gwtorm",
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",
@ -41,6 +42,7 @@ junit_tests(
"//java/com/google/gerrit/reviewdb:server",
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib:gwtorm",
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",

1
javatests/com/google/gerrit/server/query/group/BUILD
View File

@ -15,6 +15,7 @@ java_library(
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/server/schema",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/truth",

1
javatests/com/google/gerrit/server/query/project/BUILD
View File

@ -14,6 +14,7 @@ java_library(
"//java/com/google/gerrit/server",
"//java/com/google/gerrit/server/schema",
"//java/com/google/gerrit/testing:gerrit-test-util",
"//lib:guava",
"//lib/guice",
"//lib/jgit/org.eclipse.jgit:jgit",
"//lib/truth",

1
javatests/com/google/gwtexpui/safehtml/BUILD
View File

@ -5,6 +5,7 @@ junit_tests(
srcs = glob(["client/**/*.java"]),
deps = [
"//java/com/google/gwtexpui/safehtml",
"//lib:guava",
"//lib/gwt:dev",
"//lib/gwt:user",
"//lib/truth",

8
lib/truth/BUILD
View File

@ -2,10 +2,10 @@ java_library(
name = "truth",
data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"],
visibility = ["//visibility:public"],
exports = [
exports = ["@truth//jar"],
runtime_deps = [
"//lib:guava",
"//lib:junit",
"@truth//jar",
],
)
@ -13,9 +13,9 @@ java_library(
name = "truth-java8-extension",
data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"],
visibility = ["//visibility:public"],
exports = [
exports = ["@truth-java8-extension//jar"],
runtime_deps = [
":truth",
"//lib:guava",
"@truth-java8-extension//jar",
],
)