opendev/gerrit
Code Issues Proposed changes

PatchSetApprovalTest: Extend GerritBaseTests

Browse Source 
Remove the setup of KeyUtil which is now done in GerritBaseTests.

Change-Id: Ia84c41e3a21d0867e81d951e1b5a619953ead253
This commit is contained in:
David Pursehouse
2016-11-22 09:51:59 +09:00
parent aefe1e5d2f
commit 1f9b0c76ef
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-reviewdb/BUCK
View File

@@ -30,6 +30,7 @@ java_test(
srcs = glob([TESTS + 'client/**/*.java']), srcs = glob([TESTS + 'client/**/*.java']),
deps = [ deps = [
':client', ':client',
'//gerrit-server:testutil',
'//lib:gwtorm', '//lib:gwtorm',
'//lib:truth', '//lib:truth',
], ],

1
gerrit-reviewdb/BUILD
View File

@@ -37,6 +37,7 @@ junit_tests(
srcs = glob([TESTS + 'client/**/*.java']), srcs = glob([TESTS + 'client/**/*.java']),
deps = [ deps = [
':client', ':client',
'//gerrit-server:testutil',
'//lib:gwtorm', '//lib:gwtorm',
'//lib:truth', '//lib:truth',
], ],

9
gerrit-reviewdb/src/test/java/com/google/gerrit/reviewdb/client/PatchSetApprovalTest.java
View File

@@ -16,19 +16,14 @@ package com.google.gerrit.reviewdb.client;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import com.google.gwtorm.client.KeyUtil; import com.google.gerrit.testutil.GerritBaseTests;
import com.google.gwtorm.server.StandardKeyEncoder;
import org.junit.Test; import org.junit.Test;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
public class PatchSetApprovalTest { public class PatchSetApprovalTest extends GerritBaseTests {
static {
KeyUtil.setEncoderImpl(new StandardKeyEncoder());
}
@Test @Test
public void keyEquality() { public void keyEquality() {
PatchSetApproval.Key k1 = new PatchSetApproval.Key( PatchSetApproval.Key k1 = new PatchSetApproval.Key(