opendev/gerrit
Code Issues Proposed changes

Add submit rule evaluation tests for custom labels

Browse Source 
Bug issue: 2453
Change-Id: I0825b3c2d4774c17d523ac5f7890b983fa07af39
This commit is contained in:
David Ostrovsky
2014-02-07 08:57:58 +01:00
committed by David Pursehouse
parent 5cc0690f7d
commit 1fa3ca22be
4 changed files with 164 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
View File

@@ -482,18 +482,12 @@ public class ChangeJson {
return;
}
if (score != 0) {
if (score == type.getMin().getValue()) {
label.rejected = accountLoader.get(accountId);
} else if (score == type.getMax().getValue()) {
label.approved = accountLoader.get(accountId);
} else if (score < 0) {
label.disliked = accountLoader.get(accountId);
label.value = score;
} else if (score > 0 && label.disliked == null) {
label.recommended = accountLoader.get(accountId);
label.value = score;
}
if (score < 0) {
label.disliked = accountLoader.get(accountId);
label.value = score;
} else if (score > 0 && label.disliked == null) {
label.recommended = accountLoader.get(accountId);
label.value = score;
}
}