opendev/gerrit
Code Issues Proposed changes

Fix debug logs from ReviewDbBatchUpdate

Browse Source 
Change I7a66f63c77 removed the logDebug method from BatchUpdate that had
a vararg parameter for the log arguments, but the caller in the logDebug
method of ReviewDbBatchUpdate was not adapted. It still called
BatchUpdate.logDebug with an argument array, but now that array was
cast to an Object and BatchUpdate.logDebug(String, Object) was
invoked. As result of this debug logs with no arguments appeared with an
error in the logs.

E.g.

  logDebug("Updating change");

resulted in the following log entry:

  Updating change [ERROR: UNUSED LOG ARGUMENTS]

Change-Id: I6c7b642038acca4405fffc532fdc05131b635d38
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-07-03 09:15:17 +02:00
parent e397e0b192
commit 1fa756eb50
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/com/google/gerrit/server/update/ReviewDbBatchUpdate.java
View File

@@ -827,8 +827,12 @@ public class ReviewDbBatchUpdate extends BatchUpdate {
ReviewDbBatchUpdate.this.logDebug("[" + taskId + "] " + msg, t); ReviewDbBatchUpdate.this.logDebug("[" + taskId + "] " + msg, t);
} }
private void logDebug(String msg, Object... args) { private void logDebug(String msg) {
ReviewDbBatchUpdate.this.logDebug("[" + taskId + "] " + msg, args); ReviewDbBatchUpdate.this.logDebug("[" + taskId + "] " + msg);
}
private void logDebug(String msg, @Nullable Object arg) {
ReviewDbBatchUpdate.this.logDebug("[" + taskId + "] " + msg, arg);
} }
} }