opendev/gerrit
Code Issues Proposed changes

Bazel: Add fixes for --incompatible_load_{java|python}_rules_from_bzl

Browse Source 
This change is fixing "All Java build rules should be loaded from
Starlark" warning flagged by latest buildifier version: [1]. Python
rules are now also loaded from the Starlark.

Also extract codemirror library import to BUILD file. This is needed to
avoid cycle in the workspace file, after importing java rules from
Starlark.

[1] https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#native-java

Change-Id: I36192c9465d988b25cf09c250e110f15850910cd
This commit is contained in:
David Ostrovsky
2019-08-30 10:19:56 +02:00
parent efc0fe6f77
commit 20c2fd4f0b
82 changed files with 155 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/commons/BUILD
View File

@@ -1,3 +1,5 @@
load("@rules_java//java:defs.bzl", "java_library")
package(default_visibility = ["//visibility:public"])
java_library(