opendev/gerrit
Code Issues Proposed changes

Add fatal to consistency and validation error enums

Browse Source 
The code-owners plugin would like to differentiate between normal errors
and fatal errors.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ide55a2ba9ef84fa71604d42caf8cf02c66618ec7
(cherry picked from commit 5001718640)
This commit is contained in:
Edwin Kempin
2020-10-21 12:45:12 +02:00
committed by Luca Milanesio
parent 4ed924ff83
commit 21425d0d4d
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/rest-api-config.txt
View File

@@ -1701,7 +1701,7 @@ consistency problem.
|======================
|Field Name|Description
|`status` |The status of the consistency problem. +
Possible values are `ERROR` and `WARNING`.
Possible values are `FATAL`, `ERROR` and `WARNING`.
|`message` |Message describing the consistency problem.
|======================

1
java/com/google/gerrit/extensions/api/config/ConsistencyCheckInfo.java
View File

@@ -48,6 +48,7 @@ public class ConsistencyCheckInfo {
public static class ConsistencyProblemInfo {
public enum Status {
FATAL,
ERROR,
WARNING,
}

3
java/com/google/gerrit/server/git/validators/ValidationMessage.java
View File

@@ -22,6 +22,7 @@ import java.util.Objects;
*/
public class ValidationMessage {
public enum Type {
FATAL("FATAL: "),
ERROR("ERROR: "),
WARNING("WARNING: "),
HINT("hint: "),
@@ -70,7 +71,7 @@ public class ValidationMessage {
* Returns {@true} if this message is an error. Used to decide if the operation should be aborted.
*/
public boolean isError() {
return type == Type.ERROR;
return type == Type.FATAL || type == Type.ERROR;
}
@Override