Remove PatchSetAccess#byRevision(Range)

These cannot be implemented efficiently in notedb, and we can get what
we need from the secondary index in most cases, or else (in the case
of ConsistencyChecker) directly from the repo.

This change intends to provide the same behavior, and does not correct
for some sketchy usages of patch sets, like failing to check
visibility.

Change-Id: I2d961f8d2436b44308116c19597f0ed74b9d1337

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/change/ConsistencyCheckerIT.java

@@ -564,7 +564,7 @@ public class ConsistencyCheckerIT extends AbstractDaemonTest {
     ProblemInfo p = problems.get(0);
     assertThat(p.message).isEqualTo(
         "Multiple patch sets for expected merged commit " + commit.name()
-        + ": [" + ps2 + ", " + ps3 + "]");
+        + ": [" + ps2.getId() + ", " + ps3.getId() + "]");
   }
 
   private Change insertChange() throws Exception {