opendev/gerrit
Code Issues Proposed changes

Make static fields in GpgKeys and PreviewSubmit final

Browse Source 
Change-Id: Ifaf144224aeeb4339db4e445ab5bf458f89bb151
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-02-27 15:29:52 +01:00
parent 8d30fa20dd
commit 2208a5f7ce
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gpg/src/main/java/com/google/gerrit/gpg/server/GpgKeys.java
View File

@@ -63,7 +63,7 @@ import org.slf4j.LoggerFactory;
public class GpgKeys implements ChildCollection<AccountResource, GpgKey> { public class GpgKeys implements ChildCollection<AccountResource, GpgKey> {
private static final Logger log = LoggerFactory.getLogger(GpgKeys.class); private static final Logger log = LoggerFactory.getLogger(GpgKeys.class);
public static String MIME_TYPE = "application/pgp-keys"; public static final String MIME_TYPE = "application/pgp-keys";
private final DynamicMap<RestView<GpgKey>> views; private final DynamicMap<RestView<GpgKey>> views;
private final Provider<ReviewDb> db; private final Provider<ReviewDb> db;

2
gerrit-server/src/main/java/com/google/gerrit/server/change/PreviewSubmit.java
View File

@@ -51,7 +51,7 @@ import org.kohsuke.args4j.Option;
@Singleton @Singleton
public class PreviewSubmit implements RestReadView<RevisionResource> { public class PreviewSubmit implements RestReadView<RevisionResource> {
private static int MAX_DEFAULT_BUNDLE_SIZE = 100 * 1024 * 1024; private static final int MAX_DEFAULT_BUNDLE_SIZE = 100 * 1024 * 1024;
private final Provider<ReviewDb> dbProvider; private final Provider<ReviewDb> dbProvider;
private final Provider<MergeOp> mergeOpProvider; private final Provider<MergeOp> mergeOpProvider;