opendev/gerrit
Code Issues Proposed changes

Improving message when needing to reindex

Browse Source 
Old message was just telling to "run Reindex". For newbie it is
difficult to understand that the correct thing to do is running
gerrit.war with option reindex.

Change-Id: I90defeabcceaa6d8b8d7f89bf45662bcbab9ae95
This commit is contained in:
Claudio Pacchiega
2015-12-18 16:13:01 +01:00
parent f8b026d227
commit 222c9f8712
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java
View File

@@ -113,6 +113,11 @@ public class LuceneVersionManager implements LifecycleListener {
@Override
public void start() {
String runReindex =
"No index versions ready; run java -jar " +
sitePaths.gerrit_war.toAbsolutePath() +
" reindex";
FileBasedConfig cfg;
try {
cfg = loadGerritIndexConfig(sitePaths);
@@ -121,10 +126,10 @@ public class LuceneVersionManager implements LifecycleListener {
}
if (!Files.exists(sitePaths.index_dir)) {
throw new ProvisionException("No index versions ready; run Reindex");
throw new ProvisionException(runReindex);
} else if (!Files.exists(sitePaths.index_dir)) {
log.warn("Not a directory: %s", sitePaths.index_dir.toAbsolutePath());
throw new ProvisionException("No index versions ready; run Reindex");
throw new ProvisionException(runReindex);
}
TreeMap<Integer, Version> versions = scanVersions(cfg);
@@ -148,7 +153,7 @@ public class LuceneVersionManager implements LifecycleListener {
}
}
if (search == null) {
throw new ProvisionException("No index versions ready; run Reindex");
throw new ProvisionException(runReindex);
}
markNotReady(cfg, versions.values(), write);