From 7dac0215613b559ff7e96c3770a7be851383b0f8 Mon Sep 17 00:00:00 2001 From: Christian Aistleitner Date: Wed, 24 Apr 2013 20:13:30 +0200 Subject: [PATCH] Correct right border of binary header lines in side-by-side diffs While the border between the two right most columns is typically drawn in the rightmost column, binary header rows drew it in the rightmost but one column. That made the line between the two columns jump a few pixels between rows. We now draw the line number columns of binary header rows via the available helper method, and remove the now unnecessary right border of the main column. Change-Id: I5e2d0c0cc7b9fee94c0a060a8bbd9d3d71d25600 --- .../src/main/java/com/google/gerrit/client/gerrit.css | 1 - .../google/gerrit/client/patches/SideBySideTable.java | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css b/gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css index 93db54ca54..5690c40d32 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css @@ -926,7 +926,6 @@ a:hover { } .sideBySideTableBinaryHeader { - border-right: thin solid #b0bdcc; border-left: thin solid #b0bdcc; width: 100%; color: grey; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java index f4083ae421..b5f05d8ba7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java @@ -442,10 +442,7 @@ public class SideBySideTable extends AbstractPatchContentTable { m.addStyleName(Gerrit.RESOURCES.css().iconCell()); m.closeTd(); - m.openTd(); - m.setStyleName(Gerrit.RESOURCES.css().lineNumber()); - m.nbsp(); - m.closeTd(); + appendLineNumber(m, false); m.openTd(); m.setStyleName(Gerrit.RESOURCES.css().sideBySideTableBinaryHeader()); @@ -453,9 +450,7 @@ public class SideBySideTable extends AbstractPatchContentTable { m.append(line); m.closeTd(); - m.openTd(); - m.nbsp(); - m.closeTd(); + appendLineNumber(m, true); m.closeTr(); }