opendev/gerrit
Code Issues Proposed changes

Normalize metric names

Browse Source 
Make git/upload-pack a folder so we can store other metrics below it
related to git-upload-pack serving.

Change - for _ in sshd/sessions/authentication_failures.  This makes
the name more consistent with the other metrics currently exported.

Change-Id: Ica64d512de521155bf91c25be2576b70db56ca90
This commit is contained in:
Shawn Pearce 2015-11-12 14:13:51 -08:00
parent ceaa6624cd
commit 232c18da1b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/UploadPackMetricsHook.java
View File

@ -36,7 +36,7 @@ public class UploadPackMetricsHook implements PostUploadHook {
@Inject
UploadPackMetricsHook(MetricMaker metricMaker) {
upload = metricMaker.newCounter(
"git/upload-pack",
"git/upload-pack/request_count",
new Description("Total number of git-upload-pack requests")
.setRate()
.setUnit("requests"),

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshDaemon.java
View File

@ -275,7 +275,7 @@ public class SshDaemon extends SshServer implements SshInfo, LifecycleListener {
.setUnit("sessions"));
final Counter0 authFailures = metricMaker.newCounter(
"sshd/sessions/authentication-failed",
"sshd/sessions/authentication_failures",
new Description("Rate of SSH authentication failures")
.setRate()
.setUnit("failures"));